Skip to content

Move Aircraft.Fuselage.FORM_FACTOR to premission#1071

Merged
Kenneth-T-Moore merged 36 commits intoOpenMDAO:mainfrom
xjjiang:GASP_aero_premission
Apr 26, 2026
Merged

Move Aircraft.Fuselage.FORM_FACTOR to premission#1071
Kenneth-T-Moore merged 36 commits intoOpenMDAO:mainfrom
xjjiang:GASP_aero_premission

Conversation

@xjjiang
Copy link
Copy Markdown
Contributor

@xjjiang xjjiang commented Apr 1, 2026

Summary

  • Split FormFactorAndSIWB to FormFactor and SIWB.
  • Split BWBFormFactorAndSIWB to BWBFormFactor and BWBSIWB.
  • Move FormFactor and BWBFormFactor to premission.
  • Still keep SIWB and BWBSIWB in mission. Theoretically, SIWB can be moved to premission, but we would have to create an Aviary variable for it.

Related Issues

Backwards incompatibilities

None

New Dependencies

None

@xjjiang xjjiang changed the title [Draft] Move FormFactorAndSIWB and BWBFormFactorAndSIWB to premission Move Aircraft.Fuselage.FORM_FACTOR to premission Apr 6, 2026
@xjjiang xjjiang marked this pull request as ready for review April 6, 2026 20:27
Comment thread aviary/models/aircraft/test_aircraft/aircraft_for_bench_FwGm.csv Outdated
@xjjiang xjjiang requested a review from Kenneth-T-Moore April 10, 2026 22:40
Copy link
Copy Markdown
Contributor

@jkirk5 jkirk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to approve, just need to check an earlier comment was addressed

Comment thread aviary/models/aircraft/test_aircraft/aircraft_for_bench_FwGm.csv Outdated
Removed the form factor entry from the aircraft specifications.
@xjjiang xjjiang requested a review from jkirk5 April 17, 2026 19:11
@jkirk5 jkirk5 added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 17, 2026
@xjjiang xjjiang requested a review from jkirk5 April 21, 2026 20:12
@jkirk5 jkirk5 added this pull request to the merge queue Apr 21, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 21, 2026
@jkirk5 jkirk5 added this pull request to the merge queue Apr 24, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 24, 2026
@Kenneth-T-Moore Kenneth-T-Moore added this pull request to the merge queue Apr 26, 2026
Merged via the queue into OpenMDAO:main with commit 3c4adec Apr 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move FormFactorAndSIWB and BWBFormFactorAndSIWB to premission

3 participants